Re: [PATCH v3 5/6] i2c: at91: print hardware version

[Sergei Shtylyov]

Hello.

On 6/2/2015 4:18 PM, Cyrille Pitchen wrote:

> The probe() function now prints the hardware version of the I2C
> controller.

> Signed-off-by: Cyrille Pitchen <cyrille.pitchen@xxxxxxxxx>
> ---
>   drivers/i2c/busses/i2c-at91.c | 4 ++++
>   1 file changed, 4 insertions(+)

> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 67b4f15..340ce2e 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
[...]
> @@ -872,6 +874,8 @@ static int at91_twi_probe(struct platform_device *pdev)
>   			return rc;
>   	}
>
> +	dev_info(dev->dev, "version: 0x%x\n", at91_twi_read(dev, AT91_TWI_VER));

   Use "%#x" instead please -- it's shorter.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/