Re: [PATCH 2/2] of/platform: Mark all device tree resources as SHARED

[Rob Herring]

On Fri, Jun 5, 2015 at 5:51 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@xxxxxxxxx> wrote:
> Some device tree platform do not define their resources properly. i.e.
> overlapping or repeated resources.
>
> This patch mark all device tree resources as shareable.
>
> In the future this should only be set for the platforms that have
> problems.

I don't think we want to do this globally. This should be very rare
and we want to discourage any new cases.

Rob

>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> ---
>  drivers/of/platform.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index ddf8e42c9367..89cb502f8812 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -136,6 +136,8 @@ struct platform_device *of_device_alloc(struct device_node *np,
>                 if (of_irq_to_resource_table(np, res, num_irq) != num_irq)
>                         pr_debug("not all legacy IRQ resources mapped for %s\n",
>                                  np->name);
> +               for (i = 0; i < num_reg + num_irq; i++, res++)
> +                       dev->resource[i].flags |= IORESOURCE_SHARED;
>         }
>
>         dev->dev.of_node = of_node_get(np);
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/