Re: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away

From: Mark Brown
Date: Tue Jun 09 2015 - 06:10:28 EST


On Tue, Jun 09, 2015 at 08:03:47AM +0100, Lee Jones wrote:

> Admittedly this is an extreme example, but I do consider:

> init_data = of_get_regulator_init_data(<blah>);
> if (init_data)
> return -ENOMEM;

> ... neater than:

> config.init_data = of_get_regulator_init_data(<blah>);
> if (!config.init_data)
> return -ENOMEM;

Oh, I see. I pretty much see things the other way for things where the
temporary has no other users.

Attachment: signature.asc
Description: Digital signature