Re: [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions

[Julia Lawall]

On Wed, 10 Jun 2015, Sergey Senozhatsky wrote:

> On (06/10/15 07:46), Julia Lawall wrote:
> > > > Well I like it, even though it's going to cause a zillion little cleanup
> > > > patches.
> > 
> > Actually only at most 87.  There are some functions that look quite a bit 
> > nicer with the change, like:
> > 
> >  void jffs2_destroy_slab_caches(void)
> >  {
> > -       if(full_dnode_slab)
> > -               kmem_cache_destroy(full_dnode_slab);
> > -       if(raw_dirent_slab)
> > -               kmem_cache_destroy(raw_dirent_slab);
> > -       if(raw_inode_slab)
> > -               kmem_cache_destroy(raw_inode_slab);
> > -       if(tmp_dnode_info_slab)
> > -               kmem_cache_destroy(tmp_dnode_info_slab);
> > -       if(raw_node_ref_slab)
> > -               kmem_cache_destroy(raw_node_ref_slab);
> > -       if(node_frag_slab)
> > -               kmem_cache_destroy(node_frag_slab);
> > -       if(inode_cache_slab)
> > -               kmem_cache_destroy(inode_cache_slab);
> > +       kmem_cache_destroy(full_dnode_slab);
> > +       kmem_cache_destroy(raw_dirent_slab);
> > +       kmem_cache_destroy(raw_inode_slab);
> > +       kmem_cache_destroy(tmp_dnode_info_slab);
> > +       kmem_cache_destroy(raw_node_ref_slab);
> > +       kmem_cache_destroy(node_frag_slab);
> > +       kmem_cache_destroy(inode_cache_slab);
> >  #ifdef CONFIG_JFFS2_FS_XATTR
> > -       if (xattr_datum_cache)
> > -               kmem_cache_destroy(xattr_datum_cache);
> > -       if (xattr_ref_cache)
> > -               kmem_cache_destroy(xattr_ref_cache);
> > +       kmem_cache_destroy(xattr_datum_cache);
> > +       kmem_cache_destroy(xattr_ref_cache);
> >  #endif
> >  }
> > 
> 
> and some goto labels can go away either. like
> 
> [..]
> 
> err_percpu_counter_init:
> 	kmem_cache_destroy(sctp_chunk_cachep);
> err_chunk_cachep:
> 	kmem_cache_destroy(sctp_bucket_cachep);
> 
> [..]
> 
> and others.

This I find much less appealing.  The labels make clear what is needed at 
what point.  At least from a tool point of view, this is useful 
infomation.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/