Re: [PATCH v2 02/10] kdbus: use parentheses uniformly in KDBUS_ITEMS_FOREACH macro

[David Herrmann]

Hi

On Tue, Jun 9, 2015 at 11:00 PM, Sergei Zviagintsev <sergei@xxxxxxxx> wrote:
> Enclose all arguments into parentheses to stay consistent across the
> whole macro.
>
> Signed-off-by: Sergei Zviagintsev <sergei@xxxxxxxx>
> ---
>  ipc/kdbus/item.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx>

Thanks
David

> diff --git a/ipc/kdbus/item.h b/ipc/kdbus/item.h
> index 32909e2e7954..bca63b4e6e80 100644
> --- a/ipc/kdbus/item.h
> +++ b/ipc/kdbus/item.h
> @@ -28,10 +28,10 @@
>  #define KDBUS_ITEM_PAYLOAD_SIZE(_i) ((_i)->size - KDBUS_ITEM_HEADER_SIZE)
>
>  #define KDBUS_ITEMS_FOREACH(_i, _is, _s)                               \
> -       for (_i = _is;                                                  \
> +       for ((_i) = (_is);                                              \
>              ((u8 *)(_i) < (u8 *)(_is) + (_s)) &&                       \
>                ((u8 *)(_i) >= (u8 *)(_is));                             \
> -            _i = KDBUS_ITEM_NEXT(_i))
> +            (_i) = KDBUS_ITEM_NEXT(_i))
>
>  #define KDBUS_ITEM_VALID(_i, _is, _s)                                  \
>         ((_i)->size >= KDBUS_ITEM_HEADER_SIZE &&                        \
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/