Re: [PATCH v7 05/14] crypto: marvell/CESA: add TDMA support

From: Herbert Xu
Date: Wed Jun 17 2015 - 11:09:14 EST

On Wed, Jun 17, 2015 at 03:32:02PM +0200, Boris Brezillon wrote:
> Hi Herbert,
> I send you this patch alone so that you can verify I'm now properly
> manipulating the SG list. Once I have your confirmation I'll send
> the whole series again and annoy all the people in Cc one more time
> ;-).

Thanks. The only problem that I can see is the fact you're not
checking for req->src == req->dst. If they're equal then you must
not map it twice. Instead it should be mapped as DMA_BIDIRECTIONAL.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at