Re: [git pull] vfs part 2

[Linus Torvalds]

On Sun, Jun 21, 2015 at 2:12 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> +               if (count > rsize) {
> +                       WARN_ON(1);
> +                       count = rsize;
> +               }

So if we'd actually want to merge it with the warning, I'd prefer writing it as

        if (WARN_ON_ONCE(count > rsize))
              count = size;

because it's smaller and cannot spam your logs. WARN_ON_ONCE() will
only _warn_ once, but it always returns the conditional for the
warning, so the above does the right thing.

            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/