Re: [RFC][PATCH 05/13] percpu-rwsem: Optimize readers and reduce global impact

[Nicholas Mc Guire]

A bit off-topic probably
but maybe this should not be in kernel/locking/percpu-rwsem.c but in a
generic percpu location as this construct is present in the core a few times
atleast in:
 kernel/irq/irqdesc.c:kstat_irqs
 kernel/fork.c:nr_processes
 mm/memcontrol.c:mem_cgroup_read_events
 mm/memcontrol.c:mem_cgroup_read_stat

> +
> +#define per_cpu_sum(var)                                             \
> +({                                                                   \
> +     typeof(var) __sum = 0;                                          \
> +     int cpu;                                                        \
> +     for_each_possible_cpu(cpu)                                      \
> +             __sum += per_cpu(var, cpu);                             \
> +     __sum;                                                          \
> +})
> +

so maybe put it into include/linux/percpu.h ?

thx!
hofrat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/