Re: [PATCH 02/10] x86/intel_cqm: Modify hot cpu notification handling

[Vikas Shivappa]

On Wed, 24 Jun 2015, Thomas Gleixner wrote:

> On Tue, 23 Jun 2015, Vikas Shivappa wrote:
>
> > This patch modifies hot cpu notification handling in Intel cache
> > monitoring:
> >
> >  - to add a new cpu to the cqm_cpumask(which has one cpu per package)
> >   during cpu start, it uses the existing package<->core map instead of
> >   looping through all cpus in cqm_cpumask.
> >  - to search for the next online sibling during cpu exit, it uses the
> >  cpumask_any_online_but instead of looping through all online cpus.  In
> >  large systems with large number of cpus the time taken to loop may be
> >  expensive and also the time increase linearly.
>
> Of course, you forgot to mention that you added the mutex around it
> and changed the hotplug logic by moving the calls to different hotplug
> events. That part wants to be a seperate patch anyway.

Will do. will send them as seperate patches.

Thanks,
Vikas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/