Re: [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage

From: Mark Brown
Date: Tue Jul 07 2015 - 09:53:43 EST


On Tue, Jul 07, 2015 at 02:45:45PM +0100, Lee Jones wrote:
> On Tue, 07 Jul 2015, Mark Brown wrote:
> > On Mon, Jul 06, 2015 at 09:58:30AM +0100, Lee Jones wrote:

> > > + tmp = max_duty_cycle - min_mV * max_duty_cycle / vdiff;
> > > + pwm_code = tmp + max_duty_cycle * volt_mV / vdiff;

> > These need some brackets to be clear that they're correct.

> As you rightly pointed out, this stuff gets over-written in the next
> patch, although I have no problem with providing some bracketing if
> required.

Yes, please.

Attachment: signature.asc
Description: Digital signature