Re: [RESEND 08/10] regulator: pwm-regulator: Add support for continuous-voltage

From: Lee Jones
Date: Tue Jul 07 2015 - 09:47:23 EST


On Tue, 07 Jul 2015, Mark Brown wrote:

> On Mon, Jul 06, 2015 at 09:58:30AM +0100, Lee Jones wrote:
>
> > + tmp = max_duty_cycle - min_mV * max_duty_cycle / vdiff;
> > + pwm_code = tmp + max_duty_cycle * volt_mV / vdiff;
>
> These need some brackets to be clear that they're correct.

As you rightly pointed out, this stuff gets over-written in the next
patch, although I have no problem with providing some bracketing if
required.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/