Re: [PATCH] usb: ehci-platform: Fix using multiple controllers from OF

From: Alan Stern
Date: Mon Aug 03 2015 - 15:39:50 EST


On Mon, 3 Aug 2015, Alban Bedel wrote:

> When using OF defined controllers the platform data struct is shared
> between all devices, so it can't be used for device specific settings.
> However it is currently used for the OF properties
> needs-reset-on-resume and has-transaction-translator.
>
> To fix this issue move setting hcd->has_tt to the probe and
> move pdata->reset_on_resume to the private data.
>
> Signed-off-by: Alban Bedel <albeu@xxxxxxx>

That's a subtle problem and a good call on your part.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/