Re: [PATCH V2 1/6] PM / OPP: Free resources and properly return error on failure

From: Dan Carpenter
Date: Tue Aug 11 2015 - 13:14:21 EST

On Tue, Aug 11, 2015 at 08:29:38PM +0530, Viresh Kumar wrote:
> > This is weird to me, because we are going backwards. What happens if
> > we goto free_table without adding anything?
> It will WARN() today.

Then the current code is buggy.

> > I suspect it's fine, but if
> > it's a bug then this code still has problems.
> I don't think we have a bug here, we never added anything and so don't
> need to free it.
> > What about if we only increment count when _opp_add_static_v2()
> > succeeds
> That's not what we want.

If the first call to _opp_add_static_v2() fails we call
of_free_opp_table() and you say that triggers a WARN().

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at