Re: [PATCH v2 1/5] KVM: add kvm_has_request wrapper

From: Paolo Bonzini
Date: Thu Aug 13 2015 - 05:29:33 EST




On 13/08/2015 11:11, Radim KrÄmÃÅ wrote:
>> > for the new interface. maybe we can rename kvm_check_request in a separate patch somewhen.
> I wonder why haven't we copied the naming convention from bit operations
> (or if programming would be better if German was its language),
>
> kvm_test_request
> kvm_set_request
> kvm_clear_request
> kvm_test_and_clear_request
>
> The only disadvantage is that
> kvm_test_and_clear_request
> is longer than
> kvm_check_request
> 123456789
> by whooping 9 characters.
>
> I could live with that.

Yes, that would be much better.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/