Re: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

From: Thomas Gleixner
Date: Thu Aug 20 2015 - 16:03:39 EST


On Thu, 20 Aug 2015, Tim Chen wrote:
> From: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> Subject: [PATCH] sha: Enable cpuid check for Intel SHA extensions implementations

sha: is not a proper subsystem name

x86/cpufeatures: is the correct one

> Enable cpuid check for Intel SHA extensions implementations

This patch does not enable any checks. It merily adds the feature bit.

> The Intel Secure Hash Algorithm Extensions are designed to improve the performance
> of SHA-1 and SHA-256. This patch adds the check for X86_FEATURE_SHA_NI bit.

Again there is no check.

> This will allow the feature to be shown in the /proc/cpuinfo.
>
> The SHA extension programming guide is found in chapter 8 of the Intel
> Architecture Instruction Set Extensions Programming reference:
> https://software.intel.com/sites/default/files/managed/07/b7/319433-023.pdf
>
> Originally-by: Chandramouli Narayanan <mouli@xxxxxxxxxxxxxxx>

So Mouli left the company. What's the point of having his Intel mail
address here and in the Cc list?

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/