Re: [PATCH] clk: Add missing header for 'bool' definition to clk-conf.h

From: Chen-Yu Tsai
Date: Tue Aug 25 2015 - 03:41:35 EST


On Tue, Aug 25, 2015 at 2:59 PM, Michal Kubecek <mkubecek@xxxxxxx> wrote:
> On Tue, Aug 25, 2015 at 10:55:28AM +0800, Chen-Yu Tsai wrote:
>> On Tue, Aug 25, 2015 at 5:28 AM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
>> > On 08/18, Chen-Yu Tsai wrote:
>> >> of_clk_set_defaults uses the type 'bool', but clk-conf.h does not
>> >> include its definition.
>> >>
>> >> This results in a compile error when only clk-conf.h is used.
>> >>
>> >> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
>> >> Cc: stable@xxxxxxxxxxxxxxx
>> >
>> > Why is stable Cc-ed? Is there some sort of compilation failure on
>> > stable kernels?
>>
>> There isn't for now. Though I don't see why we shouldn't fix this for
>> stable kernels as well. It's possible other people or third-party
>> vendors working with stable/LTS kernels (Android?) may run into it.
>
> How about
>
> - It must fix a real bug that bothers people (not a, "This could be a
> problem..." type thing).
>
> in Documentation/stable_kernel_rules.txt?

My bad. I'll send a new version without the CC.

ChenYu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/