RE: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage muram

[Zhao Qiang]

On Tue, 2015-08-25 at 12:35 +0800, Wood Scott-B07421 wrote:
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, August 25, 2015 12:35 AM
> To: Zhao Qiang-B45475
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
> lauraa@xxxxxxxxxxxxxx; Xie Xiaobo-R63061; benh@xxxxxxxxxxxxxxxxxxx; Li
> Yang-Leo-R58472; paulus@xxxxxxxxx
> Subject: Re: [PATCH v6 3/3] qe_common: add qe_muram_ functions to manage
> muram
> 
> On Mon, 2015-08-24 at 17:31 +0800, Zhao Qiang wrote:
> 
> > @@ -187,12 +190,41 @@ static inline int qe_alive_during_sleep(void)
> >  }
> >
> >  /* we actually use cpm_muram implementation, define this for
> convenience */
> > -#define qe_muram_init cpm_muram_init
> > -#define qe_muram_alloc cpm_muram_alloc
> > -#define qe_muram_alloc_fixed cpm_muram_alloc_fixed
> > -#define qe_muram_free cpm_muram_free
> > -#define qe_muram_addr cpm_muram_addr
> > -#define qe_muram_offset cpm_muram_offset
> > +int qe_muram_init(void);
> > +
> > +#if defined(CONFIG_QUICC_ENGINE)
> > +unsigned long qe_muram_alloc(unsigned long size, unsigned long align);
> > +int qe_muram_free(unsigned long offset);
> > +void __iomem *qe_muram_addr(unsigned long offset);
> > +unsigned long qe_muram_offset(void __iomem *addr);
> > +dma_addr_t qe_muram_dma(void __iomem *addr);
> > +#else
> > +static inline unsigned long qe_muram_alloc(unsigned long size,
> > +                                         unsigned long align)
> > +{
> > +     return -ENOSYS;
> > +}
> 
> What code calls these functions without CONFIG_QUICC_ENGINE?
> 
> Are you converting qe without cpm?  Why?

CPM just work on PowerPC old boards, it is not necessary to convert it.   

> 
> -Scott


-Zhao