Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

From: Vaibhav Hiremath
Date: Tue Aug 25 2015 - 04:50:39 EST

On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote:
On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:

Driver had coding style issues where spaces were used instead
of tabs. This patch fixes them all.

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@xxxxxxxxxx>
drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++--------------------------
1 file changed, 61 insertions(+), 64 deletions(-)

Same comment as before.

How similar is this file to the other one?

I believe you are referring to include/linux/mfd/88pm80x.h

Can you reduce the size by having shared register defines?

Not sure whether I understand your comment here,
They are common defines.

PM860 only defines are named as


PM805 only defines are named as


and PM800_xxx should be common.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at