Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

[Vaibhav Hiremath]

On Tuesday 25 August 2015 04:05 PM, Lee Jones wrote:
> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>
> > On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote:
> > > On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
> > >
> > > > Driver had coding style issues where spaces were used instead
> > > > of tabs. This patch fixes them all.
> > > >
> > > > Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@xxxxxxxxxx>
> > > > ---
> > > >   drivers/mfd/88pm800.c | 125 ++++++++++++++++++++++++--------------------------
> > > >   1 file changed, 61 insertions(+), 64 deletions(-)
> > >
> > > Same comment as before.
> > >
> > > How similar is this file to the other one?
> >
> > I believe you are referring to include/linux/mfd/88pm80x.h
> >
> > > Can you reduce the size by having shared register defines?
> >
> > Not sure whether I understand your comment here,
> > They are common defines.
>
> I guess the question was a little convoluted.
>
> How about; why are the extra defines in the driver?  Why aren't all of
> them in the header file?  What is the difference between the defines
> in the C file compared with the ones defined in the header?


I do not see any difference and need of having defines separately in C
file.
That's the cleanup I was referring to in another email.

I will walk through the whole driver code and try to cleanup all such
coding related issues. Probably expect separate series here.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/