Re: [PATCH v7 8/8] clocksource: simplify ACPI code in arm_arch_timer.c
From: Fu Wei
Date: Tue Aug 25 2015 - 13:19:52 EST
On 25 August 2015 at 01:50, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Tue, 25 Aug 2015, fu.wei@xxxxxxxxxx wrote:
> You Cc the world and some more on your patch, but you fail to add the
> maintainers of the clocksource code to the Cc list. Sigh.
So sorry for that, I will add the maintainers of clocksource into cc list.
>> From: Fu Wei <fu.wei@xxxxxxxxxx>
>> The patch update arm_arch_timer driver to use the function
>> provided by the new GTDT driver of ACPI.
>> By this way, arm_arch_timer.c can be simplified, and separate
>> all the ACPI GTDT knowledge from this timer driver.
> That's not a proper changelog and this patch want's to be split in two:
> 1) Implement the new ACPI function
> 2) Make use of it
Yes, you are right , will improve this
>> index 0aa135d..99505bb 100644
>> --- a/drivers/clocksource/arm_arch_timer.c
>> +++ b/drivers/clocksource/arm_arch_timer.c
>> @@ -817,68 +817,30 @@ CLOCKSOURCE_OF_DECLARE(armv7_arch_timer_mem, "arm,armv7-timer-mem",
>> #ifdef CONFIG_ACPI
>> -static int __init map_generic_timer_interrupt(u32 interrupt, u32 flags)
>> - int trigger, polarity;
>> - if (!interrupt)
>> - return 0;
>> - trigger = (flags & ACPI_GTDT_INTERRUPT_MODE) ? ACPI_EDGE_SENSITIVE
>> - : ACPI_LEVEL_SENSITIVE;
>> - polarity = (flags & ACPI_GTDT_INTERRUPT_POLARITY) ? ACPI_ACTIVE_LOW
>> - : ACPI_ACTIVE_HIGH;
>> - return acpi_register_gsi(NULL, interrupt, trigger, polarity);
>> /* Initialize per-processor generic timer */
>> -static int __init arch_timer_acpi_init(struct acpi_table_header *table)
>> +void __init arch_timer_acpi_init(void)
> And how is that supposed to work when we have next generation CPUs
> which implement a different timer? You break multisystem kernels that
yes, you are right, If there is a next generation CPUs which
implement a different timer, (maybe) this driver can not work.
we may need a new timer driver.
(1) for now, aarch64 core always has the arch timer(this timer is
part of aarch64 architecture).
and the existing code make ARM64 kernel "select ARM_ARCH_TIMER "
(2) GTDT is designed for generic timer, so in this call "
arch_timer_acpi_init" we parse the gtdt info.
(3) once we have a ARM64 CPUs which implement a different timer, we
may need to select a right timer in the config stage.
and this timer may not be described in GTDT. So we can implement
another arch_timer_acpi_init by that time in new timer driver..
if the new time still uses GTDT(or new version GTDT), we may need to
update gtdt.c for new timer by that time.
but before we really have this new timer, I think this code is OK to use.
Do I understand your comment correctly? :-)
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/