Re: [PATCH] kernel/sysctl.c: If "count" including the terminating byte '\0' the write system call should retrun success.
From: Steven Rostedt
Date: Tue Aug 25 2015 - 15:05:45 EST
On Tue, 25 Aug 2015 13:33:57 -0400
Austin S Hemmelgarn <ahferroin7@xxxxxxxxx> wrote:
> >> How do you know that?
> > I will prove that all other write usage is not impacted later.
> Except that you can only really do this for programs that you have
> access to, and by definition you can not have access to every program
> ever written that writes to /proc.
> If you were going to do this, it would need to be itself controlled by
> another sysctl to toggle the behavior, which would need to default to
> the current behavior.
Defending the patch, I can't imagine any user space code expecting the
current behavior. The current behavior is that if you write "1\0" it
will error out instead of accepting the "1". I can't come up with a
scenario that would require userspace to expect "1\0" to fail. Can you?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/