Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9

From: Arnd Bergmann
Date: Tue Aug 25 2015 - 16:36:35 EST


On Tuesday 25 August 2015 22:07:17 Maxime Coquelin wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a750c14..57d53af 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER
> int "Maximum zone order" if ARCH_SHMOBILE_LEGACY
> range 11 64 if ARCH_SHMOBILE_LEGACY
> default "12" if SOC_AM33XX
> - default "9" if SA1111 || ARCH_EFM32
> + default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32
> default "11"
>

This looks wrong now that we can enable multiple ARMV7M platforms
together. In practice it doesn't matter much, because you wouldn't
do that for a real-life system, but out of principle this seems
like something you'd better put into the defconfig file for
both ARCH_EFM32 and ARCH_STM32. We could also think about changing
the default to "9" for any ARM_SINGLE_ARMV7M config and increasing
it again in defconfig for any platform that actually has a lot of
RAM (if any).

The SOC_AM33XX is slightly different because it increases the default
rather than reducing it, presumably because the larger allocation is
actually required (for what?).

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/