Re: [PATCH] kernel: make rcu/tree_trace.c explicitly non-modular

[Paul E. McKenney]

On Tue, Aug 25, 2015 at 02:11:09PM -0400, Paul Gortmaker wrote:
> [Re: [PATCH] kernel: make rcu/tree_trace.c explicitly non-modular] On 25/08/2015 (Tue 09:29) Josh Triplett wrote:
> 
> > On Tue, Aug 25, 2015 at 11:23:17AM -0400, Paul Gortmaker wrote:
> > > The Kconfig currently controlling compilation of this code is:
> > > 
> > > init/Kconfig:config TREE_RCU_TRACE
> > > init/Kconfig:   def_bool RCU_TRACE && ( TREE_RCU || PREEMPT_RCU )
> > > 
> > > ...meaning that it currently is not being built as a module by anyone.
> > > 
> > > Lets remove the modular code that is essentially orphaned, so that
> > > when reading the file there is no doubt it is builtin-only.
> > > 
> > > Since module_init translates to device_initcall in the non-modular
> > > case, the init ordering remains unchanged with this commit.  We could
> > > consider moving this to an earlier initcall if desired.
> > > 
> > > We don't replace module.h with init.h since the file already has that.
> > > We also delete the moduleparam.h include that is left over from
> > > commit 64db4cfff99c04cd5f550357edcc8780f96b54a2 (""Tree RCU": scalable
> > > classic RCU implementation") since it is not needed here either.
> > > 
> > > We leave some tags like MODULE_AUTHOR for documentation purposes.
> > > 
> > > Cc: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> > > Cc: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > > Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > > Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> > > Cc: Lai Jiangshan <jiangshanlai@xxxxxxxxx>
> > > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> > 
> > Seems reasonable, though leaving the MODULE_* metadata commented out at
> > the end seems odd.  I'd suggest using the DESCRIPTION to update the
> 
> That was largely driven by the desire to make as minimalist change as
> possible...

This would be for v4.4, so getting rid of the three "MODULE_*" lines
at the end makes sense, as does moving any needed info to the comment
block at the beginning of the file.

> > comment at the top (which is actually outdated and needs
> > s/classic/hierarchical/), dropping the MODULE_LICENSE (redundant with
> > the license header), and changing "MODULE_AUTHOR" into an "Author:"
> > under the copyright.
> 
> ...but I can also do it that way too; fine by me.  I'll wait a bit to
> give Paul a chance to comment before resending, in case he also wants
> some changes.

The "classic" is indeed obsolete, may as well change it while we are
at it.  I was concerned about the THIS_MODULE instances, but this appears
to be defined even for non-module builds, so should be OK.

So please do send a patch with the changes Josh called out.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/