Re: [PATCH] cred: Remove unnecessary kdebug atomic reads

From: David Howells
Date: Tue Aug 25 2015 - 19:30:53 EST

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> Did you consider doing this within no_printk()? That would break code
> which is relying on side-effects in the evaluation of a printk arg but
> that's pretty weird and I bet there isn't (and won't be) such code.

The reasons that no_printk() is like it is are (1) so that the side-effects
stay intact and (2) you still get format warnings. If someone prints a device
register, for example, it *must* work the same whether or not you use printk()
or no_printk(). Of course, printing a device register like this is probably
not a good idea...

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at