Re: [PATCH] irqdomain: remove the confused log

From: Huang Shijie
Date: Tue Aug 25 2015 - 21:37:58 EST

On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote:
> On Tue, 25 Aug 2015, Huang Shijie wrote:
> > When the dynamic debug is enabled for irq domain, the kernel will print out:
> > ------------------------------------------------------
> > irqdomain:__irq_domain_add: irq: Added domain (null)
> > ------------------------------------------------------
> >
> > It does not print out the irq domain's name, since the @domain->name is NULL.
> > Keep the log here just makes people nervous.
> Well, it might be NULL in your case, but there are enough cases where
> its not NULL and the output valuable.
In which case ?

The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function.
The @domain->name is set in other function, such as irq_domain_associate().

> Aside of that I don't understand what's making one nervous
> here. People who enable that debug stuff should know that this can be
> NULL and just deal with it. If they get nervous about it they probably
> should not try to debug that code in the first place.

Huang Shijie

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at