Re: [PATCH v4] pinctrl: mediatek: Fix multiple registration issue.

From: Linus Walleij
Date: Wed Aug 26 2015 - 08:38:26 EST


On Wed, Aug 26, 2015 at 2:32 AM, Hongzhou Yang
<hongzhou.yang@xxxxxxxxxxxx> wrote:

> Since our common driver need support main chip and PMU
> at the same time, that means it will register two
> pinctrl device, and the pinctrl_desc structure should
> be used two times.
>
> But pinctrl_desc use global static definition, then
> the latest registered pinctrl device will overwrite
> the old one's, all members in pinctrl_desc will set to
> the new one's, such as name, pins and pins numbers, etc.
> This is a bug.
>
> Move pinctrl_desc into mtk_pinctrl, assign new value for
> each pinctrl device to fix it.
>
> Cc: stable@xxxxxxxxxxxxxxx # v4.1+
> Signed-off-by: Hongzhou Yang <hongzhou.yang@xxxxxxxxxxxx>
> Reviewed-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
> In order to fix multiple registration issue, move
> pinctrl_desc into mtk_pinctrl, assign new value for
> each pinctrl device.

This patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/