Re: [PATCH 3/3] efi/arm64: clean up efi_get_fdt_params() interface

[Mark Salter]

On Wed, 2015-08-26 at 16:04 +0200, Ard Biesheuvel wrote:
> On 26 August 2015 at 15:24, Leif Lindholm <leif.lindholm@xxxxxxxxxx> 
> wrote:
> > As we now have a common debug infrastructure between core and arm64 
> > efi,
> > drop the bit of the interface passing verbose output flags around.
> > 
> > Signed-off-by: Leif Lindholm <leif.lindholm@xxxxxxxxxx>
> > ---
> >  arch/arm64/kernel/efi.c    | 2 +-
> >  drivers/firmware/efi/efi.c | 6 ++----
> >  include/linux/efi.h        | 2 +-
> >  3 files changed, 4 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
> > index 612ad5e..ab5eeb6 100644
> > --- a/arch/arm64/kernel/efi.c
> > +++ b/arch/arm64/kernel/efi.c
> > @@ -201,7 +201,7 @@ void __init efi_init(void)
> >         struct efi_fdt_params params;
> > 
> 
> Actually, one nit: struct efi_fdt_params has a verbose field that was

No it doesn't. :)

> never used in the first place, but was added [supposedly] to convey
> the same as EFI_DBG that we have now. So I think you should remove
> that as well.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/