[PATCH 03/22] perf ui tui progress: Implement the ui_progress_ops->finish() method

From: Arnaldo Carvalho de Melo
Date: Wed Aug 26 2015 - 11:58:57 EST

From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

So that we can erase the progress bar after we're done with it, avoiding
things like:


âCan't annotate unmapped_area_topdown: â
â â
âNo vmlinux file with build id a826726b5ddacfab1f0bade868f1a79â
âwas found in the path. â
â â
âNote that annotation using /proc/kcore requires CAP_SYS_RAWIOâ
âProcessinâ ââââ
â âPlease use: â â
âââââââââââ ââââ
â perf buildid-cache -vu vmlinux â
â â
âor: â
â â
â --vmlinux vmlinux â
â â
â â
âPress any key... â

Can't annotate unmapped_area_topdown:

I.e. that finished progress bar behind the error window. It is not a
problem when we end up redrawing the whole screen, but its ugly when
we present such error windows, provide a TUI method so that code like
the above may avoid this situation, as will be done with the annotation
code in the next cset.

Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
Cc: Stephane Eranian <eranian@xxxxxxxxxx>
Link: http://lkml.kernel.org/n/tip-qvktnojzwwe37pweging058t@xxxxxxxxxxxxxx
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
tools/perf/ui/tui/progress.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/tools/perf/ui/tui/progress.c b/tools/perf/ui/tui/progress.c
index c61d14b101e0..c4b99008e2c9 100644
--- a/tools/perf/ui/tui/progress.c
+++ b/tools/perf/ui/tui/progress.c
@@ -33,9 +33,26 @@ static void tui_progress__update(struct ui_progress *p)

+static void tui_progress__finish(void)
+ int y;
+ if (use_browser <= 0)
+ return;
+ ui__refresh_dimensions(false);
+ pthread_mutex_lock(&ui__lock);
+ y = SLtt_Screen_Rows / 2 - 2;
+ SLsmg_set_color(0);
+ SLsmg_fill_region(y, 0, 3, SLtt_Screen_Cols, ' ');
+ SLsmg_refresh();
+ pthread_mutex_unlock(&ui__lock);
static struct ui_progress_ops tui_progress__ops =
- .update = tui_progress__update,
+ .update = tui_progress__update,
+ .finish = tui_progress__finish,

void tui_progress__init(void)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/