Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI

[Ulf Hansson]

On 25 August 2015 at 14:04, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On 6 August 2015 at 07:39, Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>> Add GPIOLIB dependency for MMC_SDHCI.
>>
>> Problem was observed after adding the patch
>> "mmc: sdhci-of-arasan: Call OF parsing for MMC"
>> (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls
>> mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which
>> calls devm_gpiod_get_index() which returns -ENOSYS.
>>
>> Error log:
>> sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258)
>> sdhci-arasan: probe of ff160000.sdhci failed with error -38
>>
>> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
>
> Thanks, applied for next!

kbuild test robot reports a warning for this one, so I am dropping it
from my next branch.

-----
warning: (AKEBONO) selects MMC_SDHCI which has unmet direct
dependencies (MMC && HAS_DMA && GPIOLIB)
https://lists.01.org/pipermail/kbuild-all/2015-August/011824.html
-----

Perhaps we should just live with this kind of configuration problems
as this patch is trying to fix?
Looking into drivers in general I don't think we normally specify all
the Kconfig dependencies to be able to meet a successfully probe().
The GPIOLIB is just one thing out of many.

Or you have a better idea? :-)

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/