RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr

[Steve Wise]

> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@xxxxxxxxx]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: swise@xxxxxxxxxxx
> Cc: dledford@xxxxxxxxxx; sean.hefty@xxxxxxxxx; hal.rosenstock@xxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
> 
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
> 
> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
> ---

NAK.  

The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb.   They are supposed to
return 0.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/