Re: [PATCH -next] static-keys: Better error checking for static_key_enable/disable
From: Peter Zijlstra
Date: Thu Aug 27 2015 - 18:23:32 EST
On Thu, Aug 27, 2015 at 04:57:13PM -0400, Chuck Ebbert wrote:
> The warnings for static_key_enable/disable don't catch common
> errors. For example, starting with a default enabled key and
> calling enable doesn't cause a warning until the next enable
> or disable. Check explicitly for zero or one instead of allowing
> both values in every case. Generated code should be smaller too.
I explicitly intended to allow multiple consecutive static_key_enable()
calls (same for disable).
If its already enabled, calling enable should be a no-op.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/