Re: [PATCH v11 03/20] x86/stackvalidate: Compile-time stack validation

From: Andi Kleen
Date: Fri Aug 28 2015 - 13:26:29 EST

> I tried to document everything an asm coder would need to know. Also I
> have an invested interest in keeping the tool working and useful, and
> I'm listed in the MAINTAINERS file. So any frustrated people will know
> who to yell at.

I find it somewhat ironic that you're proposing to simplifying
write assembler code by making people hack some tool instead.

> > BTW how do handle the increasing number of JITs in the kernel?
> Yeah, compile-time CFI wouldn't be applicable for code which is
> generated at runtime. Maybe we will need a mechanism to allow eBPF to
> quickly create minimal CFI-like metadata corresponding to the JIT code
> it generates, which can be used by stack dumping code to identify the
> JIT code and find the previous stack pointer on the stack.

Perhaps I'm missing something, but for the hot patching you need
some solution for this, as you rely on 100% accuracy. Right?

I guess for now it could be some kind of big reader/writer lock
for JIT code and reject hot patching if something is active there.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at