Re: [RFC v6 10/40] richacl: Permission check algorithm

[Andreas GrÃnbacher]

2015-08-28 23:49 GMT+02:00 J. Bruce Fields <bfields@xxxxxxxxxxxx>:
> On Tue, Aug 04, 2015 at 01:53:08PM +0200, Andreas Gruenbacher wrote:
>> +             /*
>> +              * We don't care which class the process is in when the acl is
>> +              * not masked.
>> +              */
>> +             in_owner_or_group_class = 1;
>
> So why bother setting it at all, then?  Oh, I see, it lets you break out
> of the loop below earlier.  OK.

Comment changed to:

                /*
                 * When the acl is not masked, there is no need to determine if
                 * the process is in the group class and we can earlier break
                 * out of the loop below.
                 */

> Patch makes sense to me, ACK.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/