Re: [PATCH v2 net-next 1/2] lib: introduce strncpy_from_unsafe()
From: Steven Rostedt
Date: Fri Aug 28 2015 - 18:11:49 EST
On Fri, 28 Aug 2015 15:08:35 -0700
Alexei Starovoitov <ast@xxxxxxxxxxxx> wrote:
> On 8/28/15 2:48 PM, Steven Rostedt wrote:
> >> * On success, returns the length of the string (not including the trailing
> >> >+ * NUL).
> > I think it includes the NUL.
> oops. yes. that was a copy paste from strncpy_from_user comment.
> trace_kprobe usage wants NUL to be counted, so I intended to have it
> counted, but that brings the question what should be the semantics.
> Should it be similar to strncpy_from_user (not counting NUL) or
> similar to strlen_user (counts NUL) ?
> imo counting NUL makes a little bit more sense, since when a user says
> strncpy_from_unsafe(..., ..., 32)
> and it returns 32 as the whole buffer was filled, it looks cleaner.
I personally prefer counting the NUL. I've had issues in the past with
the strncpy_from_user() not counting it :-p
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/