Re: [PATCH] spmi: pmic-arb: Don't byte swap when reading/writing FIFO

From: Bjorn Andersson
Date: Fri Aug 28 2015 - 18:35:25 EST


On Fri 28 Aug 12:21 PDT 2015, Stephen Boyd wrote:

> We don't want to swap bytes that we're reading and writing to the
> FIFOs when we're running on a big-endian CPU. Doing so causes
> problems like where the qcom-spmi-iadc driver can't detect the
> type of device because the bytes are all mixed up. Use the raw IO
> accessors for these API instead, and collapse pmic_arb_base_read()
> into the byte reading API so that we aren't tempted to read non-FIFO
> data like commands with that function.
>
> Cc: Andy Gross <agross@xxxxxxxxxxxxxx>

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>

Regards,
Bjorn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/