Re: [PATCHv6 net-next 00/10] OVS conntrack support

From: Joe Stringer
Date: Fri Aug 28 2015 - 22:25:25 EST


On 28 August 2015 at 16:57, Simon Horman <simon.horman@xxxxxxxxxxxxx> wrote:
> On Wed, Aug 26, 2015 at 11:31:43AM -0700, Joe Stringer wrote:
>> The goal of this series is to allow OVS to send packets through the Linux
>> kernel connection tracker, and subsequently match on fields populated by
>> conntrack. This functionality is enabled through a new
>> CONFIG_OPENVSWITCH_CONNTRACK option.
>>
>> This version addresses the feedback from v5, primarily checking the behaviour
>> is correct with different configurations such as disabling
>> CONFIG_OPENVSWITCH_CONNTRACK or disabling individual conntrack features like
>> connlabels.
>>
>> The branch below has been updated with the corresponding userspace pieces:
>> https://github.com/joestringer/ovs dev/ct_20150818
>
> Hi Joe,
>
> Nice work getting this patchset in order.
>
> I am seeing the following when compiling without NF_CONNTRACK_MARK set.
>
> CC [M] net/openvswitch//conntrack.o
> net/openvswitch//conntrack.c: In function â__ovs_ct_update_keyâ:
> net/openvswitch//conntrack.c:127:24: error: âconst struct nf_connâ has no member named âmarkâ
> key->ct.mark = ct ? ct->mark : 0;
> ^
> net/openvswitch//conntrack.c: In function âovs_ct_set_markâ:
> net/openvswitch//conntrack.c:195:26: error: âstruct nf_connâ has no member named âmarkâ
> new_mark = ct_mark | (ct->mark & ~(mask));
> ^
> net/openvswitch//conntrack.c:196:8: error: âstruct nf_connâ has no member named âmarkâ
> if (ct->mark != new_mark) {
> ^
> net/openvswitch//conntrack.c:197:5: error: âstruct nf_connâ has no member named âmarkâ
> ct->mark = new_mark;
> ^
> scripts/Makefile.build:258: recipe for target 'net/openvswitch//conntrack.o' failed
> make[1]: *** [net/openvswitch//conntrack.o] Error 1
> Makefile:1386: recipe for target '_module_net/openvswitch/' failed
> make: *** [_module_net/openvswitch/] Error 2

Thanks for reporting this, I sent a patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/