Re: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks

From: Peter Zijlstra
Date: Mon Aug 31 2015 - 09:37:21 EST

I made that two patches, like:

Subject: perf: Delete PF_EXITING checks from perf_cgroup_exit() callback
From: Kirill Tkhai <ktkhai@xxxxxxxx>
Date: Mon, 31 Aug 2015 15:12:56 +0300

cgroup_exit() is not called from copy_process() after commit:

e8604cb43690 ("cgroup: fix spurious lockdep warning in cgroup_exit()")

from do_exit(). So this check is useless and the comment is obsolete.

Signed-off-by: Kirill Tkhai <ktkhai@xxxxxxxx>
Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
kernel/events/core.c | 8 --------
1 file changed, 8 deletions(-)

--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgro
struct cgroup_subsys_state *old_css,
struct task_struct *task)
- /*
- * cgroup_exit() is called in the copy_process() failure path.
- * Ignore this case since the task hasn't ran yet, this avoids
- * trying to poke a half freed task state from generic code.
- */
- if (!(task->flags & PF_EXITING))
- return;
task_function_call(task, __perf_cgroup_move, task);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at