Re: [PATCH 09/15] x86, amd: add accessor for number of cores per compute unit
From: Guenter Roeck
Date: Mon Aug 31 2015 - 11:12:04 EST
On 08/31/2015 07:57 AM, Peter Zijlstra wrote:
On Mon, Aug 31, 2015 at 06:53:58AM -0700, Guenter Roeck wrote:
What does that have to do with 'hwmon' ? The current implementation in the
driver may not be a good idea, and maybe for good reasons; I can not
comment on that. However, you concluded from that implementation that
hwmon, the subsystem, would not be able to support 'much finer grained
measurements than system wide'. I would like to understand how you reached
that conclusion.
Purely going on what this driver does here. I assumed it was
representative of things, if not then good.
Corollary: If a driver in subsystem X doesn't support interrupts,
it is a fair conclusion that subsystem X doesn't support interrupts.
The hwmon subsystem may have its limitations, and for sure would deserve
an overhaul, but at the same time people should refrain from bashing it
for no good reason.
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/