Re: [PATCH] Regulator: Suppress compiler warnings

[Krzysztof Kozlowski]

2015-09-01 1:41 GMT+09:00 Keith Busch <keith.busch@xxxxxxxxx>:
> Some compilers complain of possible uninitialized variable usage, like
> the following:
>
>   drivers/regulator/helpers.c: In function âregulator_get_bypass_regmapâ:
>   drivers/regulator/helpers.c:463:16: warning: âvalâ may be used uninitialized in this function [-Wuninitialized]
>
> The code is safe though, and only uses the variables if they were
> successfully set, so suppressing the warning with uninitialized_val.
>
> Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx>
> ---
>  drivers/regulator/helpers.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c
> index 3bbb326..bb5b22a 100644
> --- a/drivers/regulator/helpers.c
> +++ b/drivers/regulator/helpers.c
> @@ -30,7 +30,7 @@
>   */
>  int regulator_is_enabled_regmap(struct regulator_dev *rdev)
>  {
> -       unsigned int val;
> +       unsigned int uninitialized_var(val);
>         int ret;
>
>         ret = regmap_read(rdev->regmap, rdev->desc->enable_reg, &val);

This is quite common pattern so such work-around should be added to
many other functions leading to code obfuscation. Which compiler do
you have in mind?

Best regards,
Krzysztof

> @@ -114,7 +114,7 @@ EXPORT_SYMBOL_GPL(regulator_disable_regmap);
>   */
>  int regulator_get_voltage_sel_regmap(struct regulator_dev *rdev)
>  {
> -       unsigned int val;
> +       unsigned int uninitialized_var(val);
>         int ret;
>
>         ret = regmap_read(rdev->regmap, rdev->desc->vsel_reg, &val);
> @@ -453,7 +453,7 @@ EXPORT_SYMBOL_GPL(regulator_set_bypass_regmap);
>   */
>  int regulator_get_bypass_regmap(struct regulator_dev *rdev, bool *enable)
>  {
> -       unsigned int val;
> +       unsigned int uninitialized_var(val);
>         int ret;
>
>         ret = regmap_read(rdev->regmap, rdev->desc->bypass_reg, &val);
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/