Re: [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch

From: Wanpeng Li
Date: Mon Sep 07 2015 - 01:22:18 EST

On 9/7/15 12:10 PM, Srikar Dronamraju wrote:
* Wanpeng Li <> [2015-09-06 12:01:10]:

Hi Wanpeng Li,

Hi Srikar,
On 8/12/15 12:24 AM, Srikar Dronamraju wrote:
Variable sched_numa_balancing toggles numa_balancing feature. Hence
moving from a simple read mostly variable to a more apt static_branch.

Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Signed-off-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

This commit breaks Peter's queue:

kernel/sched/fair.c: In function ?task_numa_fault?:
kernel/sched/fair.c:2072: error: implicit declaration of function
kernel/sched/fair.c: In function ?task_tick_fair?:
kernel/sched/fair.c:7867: error: implicit declaration of function
make[1]: *** [kernel/sched/fair.o] Error 1
make[1]: *** Waiting for unfinished jobs....
kernel/sched/core.c:2116: warning: data definition has no type or storage
Thanks for reporting. Can you please confirm if you have the commit

It seems that the sched/core branch of Peterz's queue doesn't include this commit. So your patch should be good.

Wanpeng Li
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at