Re: [PATCH] m68k/sun3: Fix virtual addresses of clock and interrupt register

[Tom Bogendoerfer]

On Fri, Sep 25, 2015 at 09:21:34AM +0200, Geert Uytterhoeven wrote:
> On Mon, Sep 14, 2015 at 11:40 AM, Alexander Kuleshov
> <kuleshovmail@xxxxxxxxx> wrote:
> > The MMU base is 32 bits size - 0xfe000000, seems that we missed
> > one zero in the definition of the clock and interrupt register
> > addresses.
> 
> Thanks for your patch!
> 
> Have you tested this?
> 
> This means enabling/disabling interrupts never worked on Sun 3, which
> I find a bit difficult to believe.
> There are other 0x0f?????? addresses in arch/m68k/sun3/mmu_emu.c.

which are the correct one. Sun3 MMU doesn't even handle full 32bit
addresses, it's only capable of 28 bits. That's the reason why normal
m68k linux user space binaries can't work.

So this patch is broken. And I'm sure the unpatched version works.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/