Re: [PATCH] ver_linux: uniform output across various linux distros

[Alexander Kapshuk]

>> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@xxxxxxxxx>
>> ---
>> --- linux/scripts/ver_linux.orig    2015-04-13 01:12:50.000000000 +0300
>> +++ linux/scripts/ver_linux    2015-09-29 20:47:48.664509177 +0300
>> @@ -4,54 +4,112 @@
>>  # /bin /sbin /usr/bin /usr/sbin /usr/local/bin, but it may
>>  # differ on your system.
>>  #
>> +
>>  echo 'If some fields are empty or look unusual you may have an old version.'
>>  echo 'Compare to the current minimal requirements in Documentation/Changes.'
>> -echo ' '
>> +echo
>>
>>  uname -a
>> -echo ' '
>
> You do a lot of different things in this patch, making it almost
> impossible to review.  Please break them all up into individual changes,
> each patch only doing one thing (like changing "echo ' '", cleaning up
> argument lists, etc.) and resend this as a patch series that we can
> review and hopefully apply to the tree.
>
> thanks,
>
> greg k-h

 I did think of breaking down the patch into multiple bits, which
would make it easier to see what changes are being introduced, as you
suggested

Thanks very much for being patient with me.

I'll generate multiple patches and send them in later on today.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/