[PATCH 08/18] Input: goldfish - simplify function return logic

From: Javier Martinez Canillas
Date: Fri Oct 02 2015 - 09:44:42 EST


The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.

This also fixes the following make coccicheck warning:

drivers/input/keyboard/goldfish_events.c:174:1-6: WARNING: end returns can be simplified

Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
---

drivers/input/keyboard/goldfish_events.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/input/keyboard/goldfish_events.c b/drivers/input/keyboard/goldfish_events.c
index 907e4e278fce..6dfdb574bd01 100644
--- a/drivers/input/keyboard/goldfish_events.c
+++ b/drivers/input/keyboard/goldfish_events.c
@@ -171,11 +171,7 @@ static int events_probe(struct platform_device *pdev)
if (error)
return error;

- error = input_register_device(input_dev);
- if (error)
- return error;
-
- return 0;
+ return input_register_device(input_dev);
}

static struct platform_driver events_driver = {
--
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/