[PATCH 05/18] Input: retu-pwrbutton - simplify function return logic
From: Javier Martinez Canillas
Date: Fri Oct 02 2015 - 09:45:22 EST
The invoked function already returns zero on success or a negative
errno code so there is no need to open code the logic in the caller.
This also fixes the following make coccicheck warning:
drivers/input/misc/retu-pwrbutton.c:72:1-6: WARNING: end returns can be simplified
Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
---
drivers/input/misc/retu-pwrbutton.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/input/misc/retu-pwrbutton.c b/drivers/input/misc/retu-pwrbutton.c
index 30b459b6b344..55ce68a6dcbf 100644
--- a/drivers/input/misc/retu-pwrbutton.c
+++ b/drivers/input/misc/retu-pwrbutton.c
@@ -69,11 +69,7 @@ static int retu_pwrbutton_probe(struct platform_device *pdev)
if (error)
return error;
- error = input_register_device(idev);
- if (error)
- return error;
-
- return 0;
+ return input_register_device(idev);
}
static int retu_pwrbutton_remove(struct platform_device *pdev)
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/