Re: [fuse-devel] [PATCH] fuse: break infinite loop in fuse_fill_write_pages()

[Andrew Morton]

On Fri, 2 Oct 2015 12:27:45 -0700 Maxim Patlasov <mpatlasov@xxxxxxxxxxxxx> wrote:

> On 10/02/2015 04:21 AM, Konstantin Khlebnikov wrote:
> > Bump. Add more peopple in CC.
> >
> > On Mon, Sep 21, 2015 at 1:02 PM, Roman Gushchin <klamm@xxxxxxxxxxxxxx> wrote:
> >> I got a report about unkillable task eating CPU. Thge further
> >> investigation shows, that the problem is in the fuse_fill_write_pages()
> >> function. If iov's first segment has zero length, we get an infinite
> >> loop, because we never reach iov_iter_advance() call.
> 
> iov_iter_copy_from_user_atomic() eventually calls iterate_iovec(). The 
> latter silently consumes zero-length iov. So I don't think "iov's first 
> segment has zero length" can cause infinite loop.

I'm suspecting it got stuck because local variable `bytes' is zero, so
the code does `goto again' repeatedly.

Or maybe not.   A more complete description of the bug would help. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/