Re: [PATCH v6 01/53] sparc/PCI: Add mem64 resource parsing for root bus

[Yinghai Lu]

On Fri, Oct 2, 2015 at 1:00 PM, Khalid Aziz <khalid.aziz@xxxxxxxxxx> wrote:
> On Wed, 2015-09-30 at 22:52 -0700, Yinghai Lu wrote:
>> Found "no compatible bridge window" warning in boot log from T5-8.
>>
>> pci 0000:00:01.0: can't claim BAR 15 [mem 0x100000000-0x4afffffff pref]: no compatible bridge window
>>
>> That resource is above 4G, but does not get offset correctly as
>> root bus only report io and mem32.
>>
>> pci_sun4v f02dbcfc: PCI host bridge to bus 0000:00
>> pci_bus 0000:00: root bus resource [io  0x804000000000-0x80400fffffff] (bus address [0x0000-0xfffffff])
>> pci_bus 0000:00: root bus resource [mem 0x800000000000-0x80007effffff] (bus address [0x00000000-0x7effffff])
>> pci_bus 0000:00: root bus resource [bus 00-77]
>>
>> Add mem64 handling in pci_common for sparc, so we can have 64bit resource
>> registered for root bus at first.
>>
>> After patch, will have:
>> pci_sun4v f02dbcfc: PCI host bridge to bus 0000:00
>> pci_bus 0000:00: root bus resource [io  0x804000000000-0x80400fffffff] (bus address [0x0000-0xfffffff])
>> pci_bus 0000:00: root bus resource [mem 0x800000000000-0x80007effffff] (bus address [0x00000000-0x7effffff])
>> pci_bus 0000:00: root bus resource [mem 0x800100000000-0x8007ffffffff] (bus address [0x100000000-0x7ffffffff])
>> pci_bus 0000:00: root bus resource [bus 00-77]
>>
>> -v2: mem64_space should use mem_space.start as offset.
>> -v3: add IORESOURCE_MEM_64 flag
...
> PCI: Scanning PBM /pci@301
> pci_sun4v f0339c2c: PCI host bridge to bus 0009:00
> pci_bus 0009:00: root bus resource [io  0x2027e40000000-0x2027e4fffffff] (bus address [0x0000-0xfffffff])
> pci_bus 0009:00: root bus resource [mem 0x2024000100000-0x202407effffff] (bus address [0x00000000-0x7eefffff])
> pci_bus 0009:00: root bus resource [mem 0x2024100000000-0x2024dffffffff] (bus address [0xfff00000-0xdffefffff])

Looks like offset for mmio64 is not right.

Please check attached patch on the this platform  and T5-8.

Thanks

Yinghai
---
 arch/sparc/kernel/pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/arch/sparc/kernel/pci.c
===================================================================
--- linux-2.6.orig/arch/sparc/kernel/pci.c
+++ linux-2.6/arch/sparc/kernel/pci.c
@@ -659,7 +659,7 @@ struct pci_bus *pci_scan_one_pbm(struct
 				pbm->mem_space.start);
 	if (pbm->mem64_space.flags)
 		pci_add_resource_offset(&resources, &pbm->mem64_space,
-					pbm->mem_space.start);
+					pbm->mem64_space.start);
 	pbm->busn.start = pbm->pci_first_busno;
 	pbm->busn.end	= pbm->pci_last_busno;
 	pbm->busn.flags	= IORESOURCE_BUS;