Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings

[Stephen Boyd]

On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
> Tnis patch fixes the following compilation warnings:
> ...ufs-qcom.c:1201:40:
> 	warning: incorrect type in argument 1 (different address spaces)
> ...ufs-qcom.c:1201:40:
> 	expected void const *ptr
> ...ufs-qcom.c:1201:40:
> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
> ...ufs-qcom.c:1207:53:
> 	warning: incorrect type in argument 1 (different address spaces)
> ...ufs-qcom.c:1207:53:
> 	expected void const *ptr
> ...ufs-qcom.c:1207:53:
> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>
> Signed-off-by: Yaniv Gardi <ygardi@xxxxxxxxxxxxxx>
>
> ---

What version of sparse do you use? You shouldn't need to do this.

>  drivers/scsi/ufs/ufs-qcom.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 72b0ef7..b57f88a 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba)
>  		if (res) {
>  			host->dev_ref_clk_ctrl_mmio =
>  					devm_ioremap_resource(dev, res);
> -			if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
> -				dev_warn(dev,
> -					"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
> +			if (IS_ERR((__force void const *)
> +				   host->dev_ref_clk_ctrl_mmio)) {
> +				dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
>  					__func__,
> -					PTR_ERR(host->dev_ref_clk_ctrl_mmio));
> +					PTR_ERR((__force void const *)
> +						 host->dev_ref_clk_ctrl_mmio));
>  				host->dev_ref_clk_ctrl_mmio = NULL;
>  			}
>  			host->dev_ref_clk_en_mask = BIT(5);


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/