Re: [PATCH] ALSA: firewire-lib: fix compare_const_fl.cocci warnings

From: Takashi Sakamoto
Date: Mon Nov 02 2015 - 04:10:46 EST

Hi Julia,

On Nov 02 2015 16:20, Julia Lawall wrote:
On Mon, 2 Nov 2015, Takashi Sakamoto wrote:


On Nov 02 2015 15:55, Julia Lawall wrote:
Move constant to the right of binary operators.

Generated by: scripts/coccinelle/misc/compare_const_fl.cocci

CC: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>

Depends on personal taste, but the modified version does look a little
nicer to me, since one can better see the relationship between the fdf
and sfc fields.

amdtp-am824.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/sound/firewire/amdtp-am824.c
+++ b/sound/firewire/amdtp-am824.c
@@ -36,7 +36,7 @@ int amdtp_am824_set_parameters(struct am
if (err < 0)
return err;

- s->fdf = AMDTP_FDF_AM824 | s->sfc;
+ s->fdf = s->sfc | AMDTP_FDF_AM824;

* In IEC 61883-6, one data block represents one event. In ALSA, one

Could I request explainations about the advantage of this modification? I
cannot imagine good reasons for this subtle changes...

I put the reason under the --- (better see the relationship between fdf
and sfc). But if you think the code makes more sense as it is, just
ignore the patch.

Mmm. I'm sorry but I'm not wiling to add 'Reviewed-by' tag to this patch because the reason is non-functional and personal.


Takashi Sakamoto
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at