Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

From: Ludovic Desroches
Date: Mon Nov 09 2015 - 08:28:19 EST

On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote:
> [...]
> >>
> >> This doesn't seems like a case where a gpio regulator should be used
> >> and I am not sure what problem it would solve. Beside to suppress the
> >> log warnings (actually those aren't warnings but informations).
> >>
> >> Isn't sdhci_do_start_signal_voltage_switch() doing what you need here?
> >>
> >
> > It is. I am only wondering the best way to describe the hardware:
> > - No regulator but I have the 'no vqmmc regulator not found' message which
> > is a bit annoying and which can be interpreted as an issue for someone
> > who has no knowledge about this stuff.
> Hmm, should we turn them into debug messages? Both regulators are optional.

I think so. From my point of view, it is useless to indicate that
something optionnal is missing.

> > - Describe the regulator since there is one on my board. But it is not a
> > fixed regulator and even if it's close to a gpio one it is not.
> If it's driven by SDHCI internal logic, I would leave it to that.
> There are no need to describe it at all.

Ok thanks for your help.

> Kind regards
> Uffe
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at