RE: [PATCH] of: Print rather than WARN'ing when overlap check fails
From: David Laight
Date: Tue Nov 10 2015 - 04:42:34 EST
From: Michael Ellerman
> Sent: 10 November 2015 05:09
> __rmem_check_for_overlap() is called very early in boot, and on some
> powerpc systems it's not safe to call WARN that early in boot.
>
> If the overlap check fails the system will oops instead of printing a
> warning. Furthermore because it's so early in boot the console is not up
> and the user doesn't see the oops, they just get a dead system.
Wouldn't it be better to add the required checks to WARN()?
That would stop the same problem happening elsewhere.
David